Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): disable unstable scap-related perf test from perf PR comment and check #2017

Merged
merged 2 commits into from
Aug 22, 2024
Merged

chore(ci): disable unstable scap-related perf test from perf PR comment and check #2017

merged 2 commits into from
Aug 22, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 22, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

It disables the flaky scap-related perf test; moreover, it avoids polluting PRs with perf-related bot comments, instead editing existing one.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP added 2 commits August 22, 2024 10:12
@FedeDP
chore(ci): disable unstable scap-related perf test from perf PR comme…
3b543a4 
…nt and check.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
chore(ci): update perf comment if already existing instead of always …
f144484 
…writing a new one.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 22, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Aug 22, 2024
@poiana poiana added the size/M label Aug 22, 2024
@poiana poiana requested review from hbrueckner and Molter73 August 22, 2024 08:39
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     8.16%     -1.29%  [.] sinsp::next
     3.07%     -1.08%  [.] libsinsp::sinsp_suppress::process_event
     0.60%     +0.64%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     3.51%     +0.61%  [.] gzfile_read
     0.45%     +0.60%  [.] sinsp_parser::event_cleanup
     2.49%     -0.53%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     1.51%     -0.52%  [.] sinsp_parser::parse_context_switch
     4.19%     -0.50%  [.] sinsp_parser::process_event
     0.83%     +0.50%  [.] libsinsp::events::is_unknown_event
     4.47%     +0.45%  [.] next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Molter73
Molter73 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Aug 22, 2024
@poiana
Copy link
Contributor

poiana commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.15%. Comparing base (7b72eb5) to head (f144484).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2017   +/-   ##
=======================================
  Coverage   74.14%   74.15%           
=======================================
  Files         253      253           
  Lines       30834    30834           
  Branches     5405     5406    +1     
=======================================
+ Hits        22863    22864    +1     
+ Misses       7965     7951   -14     
- Partials        6       19   +13
Flag Coverage Δ
libsinsp 74.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 839efec into master Aug 22, 2024
46 checks passed
@poiana poiana deleted the chore/disable_unstable_scap_perf_test branch August 22, 2024 09:02
@FedeDP FedeDP mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@Molter73 Molter73

Labels
approved area/CI dco-signoff: yes kind/cleanup lgtm release-note-none size/M
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @Molter73